am-wd/cloudflare-api
1
0
Fork 0
Code Issues Actions Activity

Modified CloudflareResponse to fit real responses

Browse Source
This commit is contained in:
Andreas Müller
2025-06-26 11:05:50 +02:00
parent 682f25ae75
commit 2e451bcdab
7 changed files with 15 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Cloudflare.Tests/CloudflareClientTests/DeleteAsyncTest.cs
View File

@@ -184,13 +184,10 @@ namespace Cloudflare.Core.Tests.CloudflareClientTests
// Assert // Assert
Assert.IsNotNull(response); Assert.IsNotNull(response);
Assert.IsTrue(response.Success); Assert.IsTrue(response.Success);
Assert.IsNotNull(response.Errors); Assert.IsNull(response.Errors);
Assert.IsNotNull(response.Messages); Assert.IsNull(response.Messages);
Assert.IsNull(response.ResultInfo); Assert.IsNull(response.ResultInfo);
Assert.AreEqual(0, response.Errors.Count);
Assert.AreEqual(0, response.Messages.Count);
Assert.AreEqual("This is an awesome text ;-)", response.Result); Assert.AreEqual("This is an awesome text ;-)", response.Result);
Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count); Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count);

7
Cloudflare.Tests/CloudflareClientTests/GetAsyncTest.cs
View File

@@ -205,13 +205,10 @@ namespace Cloudflare.Core.Tests.CloudflareClientTests
// Assert // Assert
Assert.IsNotNull(response); Assert.IsNotNull(response);
Assert.IsTrue(response.Success); Assert.IsTrue(response.Success);
Assert.IsNotNull(response.Errors); Assert.IsNull(response.Errors);
Assert.IsNotNull(response.Messages); Assert.IsNull(response.Messages);
Assert.IsNull(response.ResultInfo); Assert.IsNull(response.ResultInfo);
Assert.AreEqual(0, response.Errors.Count);
Assert.AreEqual(0, response.Messages.Count);
Assert.AreEqual("This is an awesome text ;-)", response.Result); Assert.AreEqual("This is an awesome text ;-)", response.Result);
Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count); Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count);

7
Cloudflare.Tests/CloudflareClientTests/PatchAsyncTest.cs
View File

@@ -244,13 +244,10 @@ namespace Cloudflare.Core.Tests.CloudflareClientTests
// Assert // Assert
Assert.IsNotNull(response); Assert.IsNotNull(response);
Assert.IsTrue(response.Success); Assert.IsTrue(response.Success);
Assert.IsNotNull(response.Errors); Assert.IsNull(response.Errors);
Assert.IsNotNull(response.Messages); Assert.IsNull(response.Messages);
Assert.IsNull(response.ResultInfo); Assert.IsNull(response.ResultInfo);
Assert.AreEqual(0, response.Errors.Count);
Assert.AreEqual(0, response.Messages.Count);
Assert.AreEqual("This is an awesome text ;-)", response.Result); Assert.AreEqual("This is an awesome text ;-)", response.Result);
Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count); Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count);

14
Cloudflare.Tests/CloudflareClientTests/PostAsyncTest.cs
View File

@@ -292,13 +292,10 @@ namespace Cloudflare.Core.Tests.CloudflareClientTests
// Assert // Assert
Assert.IsNotNull(response); Assert.IsNotNull(response);
Assert.IsTrue(response.Success); Assert.IsTrue(response.Success);
Assert.IsNotNull(response.Errors); Assert.IsNull(response.Errors);
Assert.IsNotNull(response.Messages); Assert.IsNull(response.Messages);
Assert.IsNull(response.ResultInfo); Assert.IsNull(response.ResultInfo);
Assert.AreEqual(0, response.Errors.Count);
Assert.AreEqual(0, response.Messages.Count);
Assert.AreEqual("This is an awesome text ;-)", response.Result); Assert.AreEqual("This is an awesome text ;-)", response.Result);
Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count); Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count);
@@ -369,13 +366,10 @@ namespace Cloudflare.Core.Tests.CloudflareClientTests
// Assert // Assert
Assert.IsNotNull(response); Assert.IsNotNull(response);
Assert.IsTrue(response.Success); Assert.IsTrue(response.Success);
Assert.IsNotNull(response.Errors); Assert.IsNull(response.Errors);
Assert.IsNotNull(response.Messages); Assert.IsNull(response.Messages);
Assert.IsNull(response.ResultInfo); Assert.IsNull(response.ResultInfo);
Assert.AreEqual(0, response.Errors.Count);
Assert.AreEqual(0, response.Messages.Count);
Assert.AreEqual("This is an awesome text ;-)", response.Result); Assert.AreEqual("This is an awesome text ;-)", response.Result);
Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count); Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count);

7
Cloudflare.Tests/CloudflareClientTests/PutAsyncTest.cs
View File

@@ -292,13 +292,10 @@ namespace Cloudflare.Core.Tests.CloudflareClientTests
// Assert // Assert
Assert.IsNotNull(response); Assert.IsNotNull(response);
Assert.IsTrue(response.Success); Assert.IsTrue(response.Success);
Assert.IsNotNull(response.Errors); Assert.IsNull(response.Errors);
Assert.IsNotNull(response.Messages); Assert.IsNull(response.Messages);
Assert.IsNull(response.ResultInfo); Assert.IsNull(response.ResultInfo);
Assert.AreEqual(0, response.Errors.Count);
Assert.AreEqual(0, response.Messages.Count);
Assert.AreEqual("This is an awesome text ;-)", response.Result); Assert.AreEqual("This is an awesome text ;-)", response.Result);
Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count); Assert.AreEqual(1, _httpHandlerMock.Callbacks.Count);

4
Cloudflare/Models/CloudflareResponse.cs
View File

@@ -10,13 +10,13 @@
/// Errors returned by the API call. /// Errors returned by the API call.
/// </summary> /// </summary>
[JsonProperty("errors")] [JsonProperty("errors")]
public IReadOnlyList<ResponseInfo> Errors { get; set; } = []; public IReadOnlyCollection<ResponseInfo>? Errors { get; set; }
/// <summary> /// <summary>
/// Messages returned by the API call. /// Messages returned by the API call.
/// </summary> /// </summary>
[JsonProperty("messages")] [JsonProperty("messages")]
public IReadOnlyList<ResponseInfo> Messages { get; set; } = []; public IReadOnlyCollection<ResponseInfo>? Messages { get; set; }
/// <summary> /// <summary>
/// Whether the API call was successful. /// Whether the API call was successful.

2
Extensions/Cloudflare.Zones/Models/Zone.cs
View File

@@ -309,7 +309,7 @@ namespace AMWD.Net.Api.Cloudflare.Zones
/// How often the customer is billed. /// How often the customer is billed.
/// </summary> /// </summary>
[JsonProperty("frequency")] [JsonProperty("frequency")]
public string? Frequency { get; set; } public RenewFrequency? Frequency { get; set; }
/// <summary> /// <summary>
/// States if the subscription active. /// States if the subscription active.