am-wd/cloudflare-api
1
0
Fork 0
Code Issues Actions Activity

Updated DNS unit tests to latest recommendations

Browse Source
This commit is contained in:
Andreas Müller
2025-08-08 17:58:44 +02:00
parent 09e3c8ce48
commit b806fcda4a
26 changed files with 965 additions and 868 deletions
Download Patch File Download Diff File Expand all files Collapse all files

192
test/Extensions/Cloudflare.Dns.Tests/DnsAccountSettingsExtensions/UpdateDnsAccountSettingsTest.cs
View File

@@ -11,6 +11,8 @@ namespace Cloudflare.Dns.Tests.DnsAccountSettingsExtensions
[TestClass]
public class UpdateDnsAccountSettingsTest
{
public TestContext TestContext { get; set; }
private const string AccountId = "023e105f4ecef8ad9ca31a8372d0c353";
private const string ZoneId = "023e105f4ecef8ad9ca31a8372d0c354";
@@ -100,37 +102,37 @@ namespace Cloudflare.Dns.Tests.DnsAccountSettingsExtensions
var client = GetClient();
// Act
var response = await client.UpdateDnsAccountSettings(_request);
var response = await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
// Assert
Assert.IsNotNull(response);
Assert.IsTrue(response.Success);
Assert.AreEqual(_response.Result, response.Result);
Assert.AreEqual(1, _callbacks.Count);
Assert.HasCount(1, _callbacks);
var callback = _callbacks.First();
Assert.AreEqual($"/accounts/{AccountId}/dns_settings", callback.RequestPath);
var (requestPath, request) = _callbacks.First();
Assert.AreEqual($"/accounts/{AccountId}/dns_settings", requestPath);
Assert.IsNotNull(callback.Request);
Assert.IsTrue(callback.Request.ZoneDefaults.FlattenAllCnames);
Assert.IsFalse(callback.Request.ZoneDefaults.FoundationDns);
Assert.IsNotNull(callback.Request.ZoneDefaults.InternalDns);
Assert.AreEqual(ZoneId, callback.Request.ZoneDefaults.InternalDns.ReferenceZoneId);
Assert.IsFalse(callback.Request.ZoneDefaults.MultiProvider);
Assert.IsNotNull(callback.Request.ZoneDefaults.Nameservers);
Assert.AreEqual(DnsAccountNameserversType.Random, callback.Request.ZoneDefaults.Nameservers.Type);
Assert.AreEqual(86400, callback.Request.ZoneDefaults.NameserverTtl);
Assert.IsFalse(callback.Request.ZoneDefaults.SecondaryOverrides);
Assert.IsNotNull(callback.Request.ZoneDefaults.SOA);
Assert.AreEqual(604800, callback.Request.ZoneDefaults.SOA.Expire);
Assert.AreEqual(1800, callback.Request.ZoneDefaults.SOA.MinimumTtl);
Assert.AreEqual("ns1.example.org", callback.Request.ZoneDefaults.SOA.PrimaryNameserver);
Assert.AreEqual(28800, callback.Request.ZoneDefaults.SOA.Refresh);
Assert.AreEqual(3600, callback.Request.ZoneDefaults.SOA.Retry);
Assert.AreEqual(43200, callback.Request.ZoneDefaults.SOA.TimeToLive);
Assert.AreEqual("admin.example.org", callback.Request.ZoneDefaults.SOA.ZoneAdministrator);
Assert.AreEqual(DnsZoneMode.Standard, callback.Request.ZoneDefaults.ZoneMode);
Assert.IsNotNull(request);
Assert.IsTrue(request.ZoneDefaults.FlattenAllCnames);
Assert.IsFalse(request.ZoneDefaults.FoundationDns);
Assert.IsNotNull(request.ZoneDefaults.InternalDns);
Assert.AreEqual(ZoneId, request.ZoneDefaults.InternalDns.ReferenceZoneId);
Assert.IsFalse(request.ZoneDefaults.MultiProvider);
Assert.IsNotNull(request.ZoneDefaults.Nameservers);
Assert.AreEqual(DnsAccountNameserversType.Random, request.ZoneDefaults.Nameservers.Type);
Assert.AreEqual(86400, request.ZoneDefaults.NameserverTtl);
Assert.IsFalse(request.ZoneDefaults.SecondaryOverrides);
Assert.IsNotNull(request.ZoneDefaults.SOA);
Assert.AreEqual(604800, request.ZoneDefaults.SOA.Expire);
Assert.AreEqual(1800, request.ZoneDefaults.SOA.MinimumTtl);
Assert.AreEqual("ns1.example.org", request.ZoneDefaults.SOA.PrimaryNameserver);
Assert.AreEqual(28800, request.ZoneDefaults.SOA.Refresh);
Assert.AreEqual(3600, request.ZoneDefaults.SOA.Retry);
Assert.AreEqual(43200, request.ZoneDefaults.SOA.TimeToLive);
Assert.AreEqual("admin.example.org", request.ZoneDefaults.SOA.ZoneAdministrator);
Assert.AreEqual(DnsZoneMode.Standard, request.ZoneDefaults.ZoneMode);
_clientMock.Verify(m => m.PatchAsync<DnsAccountSettings, InternalUpdateDnsAccountSettingsRequest>($"/accounts/{AccountId}/dns_settings", It.IsAny<InternalUpdateDnsAccountSettingsRequest>(), It.IsAny<CancellationToken>()), Times.Once);
_clientMock.VerifyNoOtherCalls();
@@ -140,24 +142,24 @@ namespace Cloudflare.Dns.Tests.DnsAccountSettingsExtensions
public async Task ShouldUpdateDnsSettingsNone()
{
// Arrange
var request = new UpdateDnsAccountSettingsRequest(AccountId);
var req = new UpdateDnsAccountSettingsRequest(AccountId);
var client = GetClient();
// Act
var response = await client.UpdateDnsAccountSettings(request);
var response = await client.UpdateDnsAccountSettings(req, TestContext.CancellationTokenSource.Token);
// Assert
Assert.IsNotNull(response);
Assert.IsTrue(response.Success);
Assert.AreEqual(_response.Result, response.Result);
Assert.AreEqual(1, _callbacks.Count);
Assert.HasCount(1, _callbacks);
var callback = _callbacks.First();
Assert.AreEqual($"/accounts/{AccountId}/dns_settings", callback.RequestPath);
var (requestPath, request) = _callbacks.First();
Assert.AreEqual($"/accounts/{AccountId}/dns_settings", requestPath);
Assert.IsNotNull(callback.Request);
Assert.IsNull(callback.Request.ZoneDefaults);
Assert.IsNotNull(request);
Assert.IsNull(request.ZoneDefaults);
_clientMock.Verify(m => m.PatchAsync<DnsAccountSettings, InternalUpdateDnsAccountSettingsRequest>($"/accounts/{AccountId}/dns_settings", It.IsAny<InternalUpdateDnsAccountSettingsRequest>(), It.IsAny<CancellationToken>()), Times.Once);
_clientMock.VerifyNoOtherCalls();
@@ -167,196 +169,196 @@ namespace Cloudflare.Dns.Tests.DnsAccountSettingsExtensions
public async Task ShouldUpdateDnsSettingsNoneDefaults()
{
// Arrange
var request = new UpdateDnsAccountSettingsRequest(AccountId)
var req = new UpdateDnsAccountSettingsRequest(AccountId)
{
ZoneDefaults = new DnsAccountZoneDefaults()
};
var client = GetClient();
// Act
var response = await client.UpdateDnsAccountSettings(request);
var response = await client.UpdateDnsAccountSettings(req, TestContext.CancellationTokenSource.Token);
// Assert
Assert.IsNotNull(response);
Assert.IsTrue(response.Success);
Assert.AreEqual(_response.Result, response.Result);
Assert.AreEqual(1, _callbacks.Count);
Assert.HasCount(1, _callbacks);
var callback = _callbacks.First();
Assert.AreEqual($"/accounts/{AccountId}/dns_settings", callback.RequestPath);
var (requestPath, request) = _callbacks.First();
Assert.AreEqual($"/accounts/{AccountId}/dns_settings", requestPath);
Assert.IsNotNull(callback.Request);
Assert.IsNotNull(callback.Request.ZoneDefaults);
Assert.IsNull(callback.Request.ZoneDefaults.FlattenAllCnames);
Assert.IsNull(callback.Request.ZoneDefaults.FoundationDns);
Assert.IsNull(callback.Request.ZoneDefaults.MultiProvider);
Assert.IsNull(callback.Request.ZoneDefaults.Nameservers);
Assert.IsNull(callback.Request.ZoneDefaults.NameserverTtl);
Assert.IsNull(callback.Request.ZoneDefaults.SecondaryOverrides);
Assert.IsNull(callback.Request.ZoneDefaults.SOA);
Assert.IsNull(callback.Request.ZoneDefaults.ZoneMode);
Assert.IsNotNull(request);
Assert.IsNotNull(request.ZoneDefaults);
Assert.IsNull(request.ZoneDefaults.FlattenAllCnames);
Assert.IsNull(request.ZoneDefaults.FoundationDns);
Assert.IsNull(request.ZoneDefaults.MultiProvider);
Assert.IsNull(request.ZoneDefaults.Nameservers);
Assert.IsNull(request.ZoneDefaults.NameserverTtl);
Assert.IsNull(request.ZoneDefaults.SecondaryOverrides);
Assert.IsNull(request.ZoneDefaults.SOA);
Assert.IsNull(request.ZoneDefaults.ZoneMode);
_clientMock.Verify(m => m.PatchAsync<DnsAccountSettings, InternalUpdateDnsAccountSettingsRequest>($"/accounts/{AccountId}/dns_settings", It.IsAny<InternalUpdateDnsAccountSettingsRequest>(), It.IsAny<CancellationToken>()), Times.Once);
_clientMock.VerifyNoOtherCalls();
}
[TestMethod]
[ExpectedException(typeof(ArgumentOutOfRangeException))]
public async Task ShouldThrowArgumentOutOfRangeExceptionForInvalidMode()
{
// Arrange
_request.ZoneDefaults.ZoneMode = 0;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentOutOfRangeException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentOutOfRangeException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[ExpectedException(typeof(ArgumentOutOfRangeException))]
public async Task ShouldThrowArgumentOutOfRangeExceptionForInvalidNameserverType()
{
// Arrange
_request.ZoneDefaults.Nameservers.Type = 0;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentOutOfRangeException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentOutOfRangeException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[DataRow(29)]
[DataRow(86401)]
[ExpectedException(typeof(ArgumentOutOfRangeException))]
public async Task ShouldThrowArgumentOutOfRangeExceptionForInvalidNameserverTtl(int ttl)
{
// Arrange
_request.ZoneDefaults.NameserverTtl = ttl;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentOutOfRangeException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentOutOfRangeException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[DataRow(86399)]
[DataRow(2419201)]
[ExpectedException(typeof(ArgumentOutOfRangeException))]
public async Task ShouldThrowArgumentOutOfRangeExceptionForInvalidSoaExpire(int ttl)
{
// Arrange
_request.ZoneDefaults.SOA.Expire = ttl;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentOutOfRangeException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentOutOfRangeException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[DataRow(59)]
[DataRow(86401)]
[ExpectedException(typeof(ArgumentOutOfRangeException))]
public async Task ShouldThrowArgumentOutOfRangeExceptionForInvalidSoaMinimumTtl(int ttl)
{
// Arrange
_request.ZoneDefaults.SOA.MinimumTtl = ttl;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentOutOfRangeException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentOutOfRangeException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[DataRow(null)]
[DataRow("")]
[DataRow(" ")]
[ExpectedException(typeof(ArgumentNullException))]
public async Task ShouldThrowArgumentNullExceptionForMissingSoaNameserver(string nameserver)
{
// Arrange
_request.ZoneDefaults.SOA.PrimaryNameserver = nameserver;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentNullException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentNullException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[DataRow(599)]
[DataRow(86401)]
[ExpectedException(typeof(ArgumentOutOfRangeException))]
public async Task ShouldThrowArgumentOutOfRangeExceptionForInvalidSoaRefresh(int ttl)
{
// Arrange
_request.ZoneDefaults.SOA.Refresh = ttl;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentOutOfRangeException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentOutOfRangeException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[DataRow(599)]
[DataRow(86401)]
[ExpectedException(typeof(ArgumentOutOfRangeException))]
public async Task ShouldThrowArgumentOutOfRangeExceptionForInvalidSoaRetry(int ttl)
{
// Arrange
_request.ZoneDefaults.SOA.Retry = ttl;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentOutOfRangeException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentOutOfRangeException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[DataRow(299)]
[DataRow(86401)]
[ExpectedException(typeof(ArgumentOutOfRangeException))]
public async Task ShouldThrowArgumentOutOfRangeExceptionForInvalidSoaTtl(int ttl)
{
// Arrange
_request.ZoneDefaults.SOA.TimeToLive = ttl;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentOutOfRangeException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentOutOfRangeException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
[TestMethod]
[DataRow(null)]
[DataRow("")]
[DataRow(" ")]
[ExpectedException(typeof(ArgumentNullException))]
public async Task ShouldThrowArgumentNullExceptionForMissingSoaAdministrator(string admin)
{
// Arrange
_request.ZoneDefaults.SOA.ZoneAdministrator = admin;
var client = GetClient();
// Act
await client.UpdateDnsAccountSettings(_request);
// Assert - ArgumentNullException
// Act & Assert
await Assert.ThrowsExactlyAsync<ArgumentNullException>(async () =>
{
await client.UpdateDnsAccountSettings(_request, TestContext.CancellationTokenSource.Token);
});
}
private ICloudflareClient GetClient()