am-wd/cloudflare-api
1
0
Fork 0
Code Issues Actions Activity

Fixing issue with abstract class

Browse Source
This commit is contained in:
Andreas Müller
2025-08-04 22:21:10 +02:00
parent 874ea58d87
commit e977c9ec56
6 changed files with 1151 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
test/Extensions/Cloudflare.Dns.Tests/DnsRecordsExtensions/UpdateDnsRecordTest.cs
View File

@@ -19,7 +19,7 @@ namespace Cloudflare.Dns.Tests.DnsRecordsExtensions
private const string RecordId = "023e105f4ecef8ad9ca31a8372d0c355";
private Mock<ICloudflareClient> _clientMock;
private CloudflareResponse<DnsRecord> _response;
private CloudflareResponse<JObject> _response;
private List<(string RequestPath, InternalDnsRecordRequest Request)> _callbacks;
private UpdateDnsRecordRequest _request;
@@ -28,7 +28,7 @@ namespace Cloudflare.Dns.Tests.DnsRecordsExtensions
{
_callbacks = [];
_response = new CloudflareResponse<DnsRecord>
_response = new CloudflareResponse<JObject>
{
Success = true,
Messages = [
@@ -37,7 +37,7 @@ namespace Cloudflare.Dns.Tests.DnsRecordsExtensions
Errors = [
new ResponseInfo(1000, "Error 1")
],
Result = new ARecord("example.com")
Result = JObject.FromObject(new ARecord("example.com")
{
Id = RecordId,
Name = "*.example.com",
@@ -53,7 +53,7 @@ namespace Cloudflare.Dns.Tests.DnsRecordsExtensions
ModifiedOn = DateTime.Parse("2014-01-01T05:20:00.12345Z"),
CommentModifiedOn = DateTime.Parse("2024-01-01T05:20:00.12345Z"),
TagsModifiedOn = DateTime.Parse("2025-01-01T05:20:00.12345Z"),
}
})
};
_request = new UpdateDnsRecordRequest(ZoneId, RecordId, "example.com")
@@ -75,7 +75,23 @@ namespace Cloudflare.Dns.Tests.DnsRecordsExtensions
// Assert
Assert.IsNotNull(response);
Assert.IsTrue(response.Success);
Assert.AreEqual(_response.Result, response.Result);
Assert.IsNotNull(response.Result);
Assert.IsInstanceOfType<ARecord>(response.Result);
Assert.AreEqual(RecordId, response.Result.Id);
Assert.AreEqual("*.example.com", response.Result.Name);
Assert.AreEqual("96.7.128.175", response.Result.Content);
Assert.AreEqual("Domain verification record", response.Result.Comment);
Assert.AreEqual(1, response.Result.TimeToLive);
Assert.IsTrue(response.Result.Proxied);
Assert.IsTrue(response.Result.Proxiable);
Assert.IsNotNull(response.Result.Settings);
Assert.IsNotNull(response.Result.Meta);
Assert.IsNotNull(response.Result.CreatedOn);
Assert.IsNotNull(response.Result.ModifiedOn);
Assert.IsNotNull(response.Result.CommentModifiedOn);
Assert.IsNotNull(response.Result.TagsModifiedOn);
Assert.AreEqual(1, _callbacks.Count);
@@ -87,7 +103,7 @@ namespace Cloudflare.Dns.Tests.DnsRecordsExtensions
Assert.AreEqual(DnsRecordType.A, callback.Request.Type);
Assert.AreEqual("127.0.1.22", callback.Request.Content);
_clientMock.Verify(m => m.PatchAsync<DnsRecord, InternalDnsRecordRequest>($"/zones/{ZoneId}/dns_records/{RecordId}", It.IsAny<InternalDnsRecordRequest>(), It.IsAny<CancellationToken>()), Times.Once);
_clientMock.Verify(m => m.PatchAsync<JObject, InternalDnsRecordRequest>($"/zones/{ZoneId}/dns_records/{RecordId}", It.IsAny<InternalDnsRecordRequest>(), It.IsAny<CancellationToken>()), Times.Once);
_clientMock.VerifyNoOtherCalls();
}
@@ -95,7 +111,7 @@ namespace Cloudflare.Dns.Tests.DnsRecordsExtensions
{
_clientMock = new Mock<ICloudflareClient>();
_clientMock
.Setup(m => m.PatchAsync<DnsRecord, InternalDnsRecordRequest>(It.IsAny<string>(), It.IsAny<InternalDnsRecordRequest>(), It.IsAny<CancellationToken>()))
.Setup(m => m.PatchAsync<JObject, InternalDnsRecordRequest>(It.IsAny<string>(), It.IsAny<InternalDnsRecordRequest>(), It.IsAny<CancellationToken>()))
.Callback<string, InternalDnsRecordRequest, CancellationToken>((requestPath, request, _) => _callbacks.Add((requestPath, request)))
.ReturnsAsync(() => _response);